Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for custom proxy headers using a ConfigMap #246

Merged
merged 3 commits into from
Feb 16, 2017
Merged

Add support for custom proxy headers using a ConfigMap #246

merged 3 commits into from
Feb 16, 2017

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Feb 7, 2017

fixes #180

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 7, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@aledbf aledbf force-pushed the set-headers branch 3 times, most recently from 7285c68 to cbccff8 Compare February 7, 2017 19:03
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 44.223% when pulling cbccff82cd3ed57b357e620795b6566f74809e93 on aledbf:set-headers into 4eb527d on kubernetes:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 44.183% when pulling cbccff82cd3ed57b357e620795b6566f74809e93 on aledbf:set-headers into 4eb527d on kubernetes:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 44.223% when pulling 5cc5669 on aledbf:set-headers into 2045786 on kubernetes:master.

@bigkraig
Copy link
Contributor

This is a huge help for what I am working on, thanks!!

@bigkraig
Copy link
Contributor

bigkraig commented Feb 11, 2017 •
edited
Loading

@aledbf, any chance we can get the StoreToNodeLister added? I am not sure how else to get the node IPs for my NodePort targets.

I sent you a PR that includes the Node lister aledbf#1

@aledbf aledbf changed the title WIP: Add support for custom proxy headers using a ConfigMap Add support for custom proxy headers using a ConfigMap Feb 11, 2017
@coveralls
Copy link

Coverage Status

Coverage increased (+1.4%) to 45.818% when pulling f7a27eb on aledbf:set-headers into 2045786 on kubernetes:master.

@aledbf aledbf assigned justinsb and unassigned justinsb Feb 11, 2017
@aledbf aledbf merged commit b5819d8 into kubernetes:master Feb 16, 2017
@aledbf aledbf deleted the set-headers branch February 16, 2017 13:34
@n1koo n1koo mentioned this pull request May 18, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. nginx
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

adding proxy_set_header entries using an annotation
6 participants
@aledbf @k8s-reviewable @coveralls @bigkraig @justinsb @k8s-ci-robot